Abstract: This paper takes Shanxi coking coal as the research object, based on the main coal field exploration results, relevant geological data and actual coal chemical achievements in China, and using the theories and methods of coal geology, coal petrology, coal chemistry and coal chemical engineering, expounds the coal rock and coal quality characteristics of coking coal in China at the present stage, and discusses the influence of geological factors on the coking characteristics of coking coal from the aspects of coal rock composition, coal quality change characteristics and sedimentary environment characteristics of the study area. The composition of macerals, the types and proportion of sub components and the differences of coal quality characteristics in coking coal are closely related to the coal forming environment, which is mainly affected by the changes of the nature of coal forming basin, provenance components and sedimentary environment. The nature of coal forming basin base and provenance and the change of sedimentary environment directly affect the coal quality characteristics of coking coal, and the sedimentary environment also affects the type, sub component content and composition of macerals. Finally, the same kind of coal shows different coke properties. In the process of coal formation, the content of vitrinite in coal formed during water invasion is significantly higher than that in coal formed during water regression. When the coal facies are divided, the content of coal vitrinite formed in the low-level swamp environment is always the highest, and the wetland herb swamp wet forest swamp facies is the most typical; The coal formed in the high-level protrusion swamp environment is mainly inertinite, and the dry forest swamp facies is the most typical. The metamorphic degree of coal is often an important factor affecting the characteristics of coking coal. The volatile yield of coal in low rank coal is often affected by coal rock components. The volatile yield of EXINITE is the highest, inertinite is the lowest, and vitrinite is between the two.